Committed. One question: + .reserved_first_sector = 1,
This line claims that overwriting first sector of nilfs won't destroy any data or metadata. Is it so? Jiro SEKIBA wrote: > Hi, > > Thank you very much for the comments! > I revised the patch to reflect the comments. > > >> + { >> + grub_error(GRUB_ERR_BAD_FS,"btree corruption\n"); >> + return -1; >> + } >> What do you think about possible fallback to iterate over all nodes in case >> of fs corruption? >> > > The case that btree is corrupted, it's very hard to take any action to recover > because it is not possible to distinguish which block has meta data > or which block has data without btree information. > > nilfs2 has ability to mount old checkpoint by specifying checkpoint number. > So using old checkpoint is one of the possible fallback if all the blocks > belonging to the old checkpoint is healthy. But it requires some more work. > > thanks, > > regards > > ------------------------------------------------------------------------ > > > ------------------------------------------------------------------------ > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel