On 06/05/2010 02:22 AM, Grégoire Sutre wrote:
> Hi,
>
> The attached patch uses grub_partition_get_start (p) instead of p->start
> in grub-setup's iteration over partitions.  While we are at it, also
> use grub_partition_get_len (p) instead of p->len.
Go ahead
>
> An alternative would be to assume that partitions are properly nested,
> and therefore iterate only over the top-level ones (i.e. those with
> p->parent == NULL).  In that case, we could equivalently use p->start.
>
>
> In the check for non-empty embedding area, the patch uses <= instead of
> == (as we may have embed_region.start == 1 && embed_region.end == 0).
>
> Comments?
>
> Grégoire
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to