On 12/02/2010 10:29 PM, Colin Watson wrote: > On Thu, Dec 02, 2010 at 01:15:10PM -0800, Seth Goldberg wrote: > >> When assembling grub-core/kern/i386/pc/startup.S, gas on some platforms >> chokes on this line: >> >> movl $((LOCAL(bypass_table_end) - LOCAL(bypass_table)) / 2), %ecx >> >> Because on non i386-linux targets, '/' is used as a comment delimiter >> for compatibility purposes. This can be overridden with the --divide >> switch. >> >> Since the default for gas on these platforms is to use he division >> operator as a comment delimiter, the "-Wa,--divide" flags need to be >> passed on the gcc command line when assembling such files. >> > Can we just use >> 1 instead? > > This was my first thought. But for maintenance reasons it would be better if we can make all platforms behave the same. Can we just inconditionally add -Wa,--divide to TARGET_ASFLAGS ?
-- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
