On 12/30/2010 07:29 AM, [email protected] wrote: > Alas, AmigaOS has mostly passed beyond the veil, but one can still find > small bugs sometimes: > > === modified file 'grub-core/partmap/amiga.c' > --- grub-core/partmap/amiga.c 2010-03-26 14:44:13 +0000 > +++ grub-core/partmap/amiga.c 2010-12-30 06:25:26 +0000 > @@ -87,7 +87,7 @@ > if (grub_disk_read (disk, pos, 0, sizeof (rdsk), &rdsk)) > return grub_errno; > > - if (grub_strcmp ((char *) rdsk.magic, "RDSK") == 0) > + if (grub_strncmp ((char *) rdsk.magic, "RDSK", sizeof(rdsk.magic)) == > 0) > { > /* Found the first PART block. */ > next = grub_be_to_cpu32 (rdsk.partitionlst); > > > I both like and dislike using strcmp() for this purpose. I kind of like > keeping it as a string, but strcmp()... Anyway, minimal solution. > > Nice catch. I fixed it by using the correct grub_memcmp.
-- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
