On 15.05.2011 04:31, Bruce Dubbs wrote: > Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> Hello, all >> >> I'm proud to announce the release of GNU GRUB version 1.99. > > Congratulations on the release. As one who builds almost everything > form source, the download and build went very smoothly. Thank you. > > I want to share some nits with you. Use them or ignore them as you > please. > > -- Bruce > > 1. The install creates an empty directory: /usr/share/grub > It's empty only if no freetype or no unifont was found > 2. There were several trivial build warnings: > > grub_script.yy.h:293: warning: 'yy_flex_strncpy' declared 'static' but > never defined > grub_script.yy.c:2241: warning: unused parameter 'yyscanner' > grub_script.yy.c:2482: warning: unused parameter 'yyscanner' These warnings come from flex autogenerated code > config.status: WARNING: 'util/grub.d/10_linux.in' seems to ignore the > --datarootdir setting > config.status: WARNING: 'util/grub.d/20_linux_xen.in' seems to ignore > the --datarootdir setting > config.status: WARNING: 'util/grub-install.in' seems to ignore the > --datarootdir setting > config.status: WARNING: 'util/grub-mknetdir.in' seems to ignore the > --datarootdir setting --datarootdir isn't supported by us (yet?). > fs/btrfs.c: In function 'grub_btrfs_read_logical': > fs/btrfs.c:592: warning: 'err' may be used uninitialized in this function Spurious warning with your gcc. I'll silence it. > grub_script.yy.h:293: warning: 'yy_flex_strncpy' declared 'static' but > never defined > grub_script.yy.c: In function 'yy_fatal_error': > grub_script.yy.c:2241: warning: unused parameter 'msg' > grub_script.yy.c:2241: warning: unused parameter 'yyscanner' > grub_script.yy.c: At top level: > grub_script.yy.c:2279: warning: no previous prototype for 'yyget_column' > grub_script.yy.c:2322: warning: no previous prototype for 'yyset_column' > grub_script.yy.c: In function 'yy_flex_strncpy': > grub_script.yy.c:2482: warning: unused parameter 'yyscanner' ditto > lib/libgcrypt-grub/cipher/camellia.c:450: warning: no previous > prototype for 'camellia_setup128' > lib/libgcrypt-grub/cipher/camellia.c:661: warning: no previous > prototype for 'camellia_setup256' > lib/libgcrypt-grub/cipher/camellia.c:947: warning: no previous > prototype for 'camellia_setup192' > lib/libgcrypt-grub/cipher/camellia.c: In function 'camellia_setup192': > lib/libgcrypt-grub/cipher/camellia.c:951: warning: implicit > declaration of function 'memcpy' > lib/libgcrypt-grub/cipher/camellia.c: At top level: > lib/libgcrypt-grub/cipher/camellia.c:969: warning: no previous > prototype for 'camellia_encrypt128' > lib/libgcrypt-grub/cipher/camellia.c:1059: warning: no previous > prototype for 'camellia_decrypt128' > lib/libgcrypt-grub/cipher/camellia.c:1152: warning: no previous > prototype for 'camellia_encrypt256' > lib/libgcrypt-grub/cipher/camellia.c:1266: warning: no previous > prototype for 'camellia_decrypt256' > lib/libgcrypt-grub/cipher/rijndael.c: In function 'do_setkey': > lib/libgcrypt-grub/cipher/rijndael.c:173: warning: comparison between > signed and unsigned > lib/libgcrypt-grub/cipher/serpent.c: In function 'serpent_key_prepare': > lib/libgcrypt-grub/cipher/serpent.c:589: warning: comparison between > signed and unsigned These files copied verbatim from libgcrypt. They must be fixed there first. > reed_solomon.c: Assembler messages: > reed_solomon.c:2: Warning: ignoring changed section attributes for .text > Fixing this warning would require significant changes. They were too big to squeeze into 1.99.
-- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
