On 24.07.2011 13:48, devkral wrote: > Am Donnerstag, den 21.07.2011, 21:51 +0200 schrieb Vladimir > 'φ-coder/phcoder' Serbinenko: >> Please keep the list CC'ed. Keep the list CC'ed. Idon't accept patches sent privately >> On 21.07.2011 21:39, devkral wrote: >>> sorry, I don't understand the uuid-LUKS logic of grub-probe and dmsetup >>> doesn't support this check. >> dmsetup info /dev/mapper/mycrypt gives: >> ... >> UUID: CRYPT-LUKS1-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-mycrypt_unformatted >> And with grub-probe -t cryptodisk_uuid /mnt/crypt >> you have: >> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx >> Where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is the unique UUID which is also >> used in /dev/disk/by-uuid/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx, just >> formatted differently. >> The patch as is unnecessarily uses a heavily different codepath than >> non-crypt ones. From maintainance point of view this is unacceptable. >> > I have had a logical mistake in my patch (the ':' doesn't vanish like > dmsetup … -c -o vg_name). Here the corrected version of my patch.
-- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
