On 21.09.2011 23:29, Mario Limonciello wrote:
> +#if !defined(__MINGW32__)
>    s = grub_util_get_fd_sectors (fd, &log_secsize);
>    grub_util_fd_seek (fd, dev, (s << log_secsize) - 512);
> +#endif
This would make GRUB behave erratically if this code is ever reached
which is always a bad thing. While doing something like
#if defined (GRUB_UTIL) && ! defined (__MINGW32__)
on whole function is a cheap and functionality-reducing way to port,
correct way is to add a windows equivalent of this call (getting
disk/file size)

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to