On 04.05.2012 05:43, Bean wrote: > On Fri, May 4, 2012 at 3:50 AM, Vladimir 'φ-coder/phcoder' Serbinenko > <phco...@gmail.com> wrote: >> On 03.05.2012 21:40, Bean wrote: >>> + if (rsm->asm_netbuff) >>> + grub_netbuff_free (rsm->asm_netbuff); >> Could you make grub_netbuff_free skip on NULL and so simplify it here? > Hi, > > I think this is one of the few place where netbuff can be NULL (it > usually return error when grub_netbuff_alloc return NULL), since > grub_netbuff_free is called a lot, it might have a little performance > impact when we do the check in grub_netbuff_free. It's not called that much that this additional check would be a performance hit. But it decreases the probability of similar bugs to essentially zero. >> When you've done this you can commit bug.diff. >> Thank you >> >> -- >> Regards >> Vladimir 'φ-coder/phcoder' Serbinenko >> >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >> > >
-- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
