On Saturday, July 20, 2013 05:47:57 PM Andrey Borzenkov wrote: > > - int string_left_offset = self->icon_width + icon_text_space; > > - int string_top_offset = (item_height - (ascent + descent)) / 2 + > > ascent; > > + int item_left_offset = self->icon_width + icon_text_space; > > + int item_top_offset = (item_height - (ascent + descent)) / 2 + ascent;
> Is there any reason for renaming? Such changes usually obfuscate main > patch content and better done as separate patch with clear explanation. I have renamed these values to differ left and top offsets for non-selected item and for selected item. So the meanings of the values are cleared and easy-to-get. I can do these changes in a separate patch if it's needed. Just the patch and the renaming are about the same concept so it should be applied together. -- With best regards, _______________________________ Vladimir Testov, ROSA Laboratory. www.rosalab.ru _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
