On 16.11.2013 15:45, Leif Lindholm wrote: > On Sat, Nov 16, 2013 at 03:28:35PM +0100, Leif Lindholm wrote: >> I pushed the above, and almost immediately I realised that in this >> situation we also need to store u-boot's version of r9 on return: >> >> diff --git a/grub-core/kern/arm/uboot/startup.S >> b/grub-core/kern/arm/uboot/start >> index df1e329..26313ba 100644 >> --- a/grub-core/kern/arm/uboot/startup.S >> +++ b/grub-core/kern/arm/uboot/startup.S >> @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall) >> mov lr, pc >> ldr pc, grub_uboot_syscall_ptr >> str r8, gd_backup >> + str r9, gd_backup + 4 >> >> ldr r8, transition_space >> ldr lr, transition_space + 4 >> >> Can I push this fix too? > > Umm, at second thought - the gd pointer(s) wouldn't be changing. > So the correct fix would rather be to > - str r8, gd_backup > ? > Was this tested? > / > Leif > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
