В Fri, 12 Dec 2014 07:01:31 -0600 Victor Lowther <victor.lowt...@gmail.com> пишет:
> On Fri, Dec 12, 2014 at 5:54 AM, Andrei Borzenkov <arvidj...@gmail.com> wrote: > > В Thu, 11 Dec 2014 13:58:04 -0600 > > Victor Lowther <victor.lowt...@gmail.com> пишет: > > > >> There are usecases for running TFTP and HTTP on nonstandard ports. This > >> patch allows you to specify nonstandard ports with the following syntax: > > [ snip ] > > > No, that's wrong. grub_net_open_real should not have any hardcoded > > dependencies on supported protocols. "pxe" and "pxe:" are just for > > compatibility with legacy configuration. Any new code should rely on > > protocol modules registration. > > Er, it seemed like the natural place based on it being the only place where > the parsing happens. > > Where should I put it then? > In the same function after we got server name. Just check whether it has extra ',' and parse accordingly. > > Do not overcomplicate things. You just need to add additional server > > name parsing after protocol was extracted. > > My familiarity with the grub codebase started on Tuesday -- I have no idea > what is overcomplicated and what is not. > > > And please also update documentation to indicate new syntax. > > Where are the docs? Nothing jumped out at me when grepping through the > codebase. docs/grub.texi. It is mentioned in 13.1 How to specify devices. Yes, documentation needs some love. _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
