Hi Vladimir, On Thu, Jun 15, 2017 at 11:12:32AM +0000, Vladimir 'phcoder' Serbinenko wrote: > Good. Thank you for doing this. Please don't mark obscure error messages > for translation (N_). In this patch no string needs translation. Would it > also be possible to add some tests?
Thanks for the review; I've sent v2 which removes the N_() calls and adds an ext4_encrypt test to grub-fs-tester. One caveat is that formatting and mounting a filesystem with '-O encrypt' is only possible with e2fsprogs v1.43+ and Linux v4.1+. Perhaps those should be detected as a prerequisite? I don't think there's a good way to detect the encryption support other than trying it and seeing if it works, though. Eric _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
