On 12/18/2017 10:30 PM, Eric Snowberg wrote:
>> This is not good. It will not work if you cross compile.
>
> What error do you see on a cross compile? I see __sparc__ used throughout
> the code.
I agree. This should not cause any issues when cross-compiling, the
cross-compiler
targeting __$ARCH__ always comes with the same compiler macros and definitions
as the native compiler.
>>> +static void
>>> +check_hba_identifiers (const char *sysfs_path, int *vendor, int *device_id)
>>> +{
>>> + char *ed = strstr (sysfs_path, "host");
>>> + size_t path_size;
>>> + char *p = NULL, *path = NULL;
>>
>> I think that you do not need to initialize *p here.
>
> I’ll remove the initialization.
I think that change was suggested by me as the code wouldn't build with
-Werror without the initialization. -Werror is the default when building
GRUB, if I remember correctly.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
