On 06/14/2018 03:21 PM, Daniel Kiper wrote: > Hi Goffredo, > > On Sun, Jun 03, 2018 at 08:53:39PM +0200, Goffredo Baroncelli wrote: >> >> Hi All, >> >> the aim of this patches set is to provide support for a BTRFS raid5/6 >> filesystem in GRUB. >> >> The first patch, implements the basic support for raid5/6. I.e this works >> when >> all the disks are present. >> >> The next 5 patches, are preparatory ones. >> >> The 7th patch implements the raid5 recovery for btrfs (i.e. handling the >> disappearing of 1 disk). >> The 8th patch makes the code for handling the raid6 recovery more generic. >> The last one implements the raid6 recovery for btrfs (i.e. handling the >> disappearing up to two disks). >> >> I tested the code in grub-emu, and it works both with all the disks, >> and with some disks missing. I checked the crc32 calculated from grub and >> from linux and these matched. Finally I checked if the support for md raid6 >> still works properly, and it does (with all drives and with up to 2 drives >> missing) >> >> Comments are welcome. > > In general I am happy that you are doing this work. However, I have just > realized that in some cases you are agreeing with my comments and then > you do not incorporate the changes which I was asking for. So, I would > be more happy if you instead of saying OK just do requested changes.
This is not good. I apologize, If this happened it was a my mistake. When I put OK, this means that I agree with your reviews and I incorporate them. Now I am reviewing your old comments > Otherwise you lose your and my time. Hence, I would like ask you to > check carefully all my comments for v4 and v5 (at least), apply all > requested changes with which you agree and then post v6. > > Sorry for being blunt. > > Daniel > -- gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it> Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5 _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel