On Thu, Nov 15, 2018 at 12:23:32PM +1300, Matthew Garrett wrote: > On Thu, Nov 15, 2018 at 6:39 AM Daniel Kiper <dki...@net-space.pl> wrote: > > > Could you be more C-ish? E.g. s/Major/major/, s/Minor/minor/, etc. > > These are the spec-defined member names, so I've a mild preference for > keeping them that way - it makes it easier to compare with the spec > and update stuff with later spec revisions. I've updated everything > else, I'll resend now.
OK, but please add the title of spec which you are referring to into the comment before these structs. This way it will be much easier to understand why you diverge from the common naming convention. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
