On 28.01.19 13:27, Daniel Kiper wrote:
> On Fri, Jan 25, 2019 at 12:45:16PM +0100, Alexander Graf wrote:
>> There are a few spots in the PE generation code for EFI binaries that uses
>> the section alignment rather than file alignment, even though the alignment
>> is really only file bound.
>>
>> Replace those cases with the file alignment constant instead.
>>
>> Reported-by: Daniel Kiper <dki...@net-space.pl>
>> Signed-off-by: Alexander Graf <ag...@suse.de>
>
> Great! However, this patch misses changes for EFI32_HEADER_SIZE
> and EFI64_HEADER_SIZE macros. In general I think about
> s/GRUB_PE32_SECTION_ALIGNMENT/GRUB_PE32_FILE_ALIGNMENT/
> I have asked about that in my earlier emails too...
If you have such a strong opinion, why don't you just simply do the
patch and I review it? The way we're bouncing this back and forth is
unproductive for both of us.
Alex
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
