On Fri, Mar 08, 2019 at 12:21:20PM +0000, Andre Przywara wrote: > On Fri, 8 Mar 2019 13:01:33 +0100 > Daniel Kiper <daniel.ki...@oracle.com> wrote: > > > On Thu, Mar 07, 2019 at 03:14:14PM +0000, Andre Przywara wrote: > > > From: Andrei Borzenkov <arvidj...@gmail.com> > > > > > > In respone to a BOOTREQUEST packet a BOOTP server would answer with a > > > BOOTREPLY packet, which ends the conversation for good. > > > DHCP uses a 4-way handshake, where the initial server respone is an OFFER, > > > which has to be answered with REQUEST by the client again, only to be > > > completed by an ACKNOWLEDGE packet from the server. > > > > > > Teach the grub_net_process_dhcp() function to deal with OFFER packets, > > > and treat ACK packets the same es BOOTREPLY packets. > > > > > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com> > > > Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> > > > > This patch has changed and you retained my RB and not explained why it > > has changed. Could you tell us what has happened? Next time please drop > > RB if you change the code significantly. > > Mmh, weird. I didn't touch this patch at all, that's why just added your > R-B to the commit message. I think what happened is that the subtle change > in patch 05/10 (just removing the not needed brackets, as per your comment > on v2 4/9), caused the *diff* to be vastly different. I remember fixing it > up in the "git rebase -i" process. I just did a: > $ diff -u <(git show dhcp-v2~2:grub-core/net/bootp.c) <(git show > dhcp-v3~2:grub-core/net/bootp.c) > and that showed only unrelated changes. > So the resulting code change is actually identical, it's just that diff > took a different approach at expressing that. > > Sorry for the confusion, hope that your R-b: still stands.
Gosh... I made a mistake when I have been comparing the patches. My fault. So, I am taking back my rant. Sorry about that. R-b: still stands. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
