On Fri, Mar 22, 2019 at 04:15:35PM +0100, Vladimir 'phcoder' Serbinenko wrote: > From ce156e3274e53089b7a9ba432262b8aab75d8ad0 Mon Sep 17 00:00:00 2001 > From: Vladimir Serbinenko <phco...@gmail.com> > Date: Fri, 22 Mar 2019 16:13:11 +0100 > Subject: [PATCH] Propagate GNU_PRINTF from gnulib vfprintf > > gnulib now replaces vfprintf and hence it becomes GNU_PRINTF
Missing SOB. > --- > include/grub/emu/misc.h | 14 +++++--------- > include/grub/err.h | 3 ++- > 2 files changed, 7 insertions(+), 10 deletions(-) > > diff --git a/include/grub/emu/misc.h b/include/grub/emu/misc.h > index 59b8b35fc..ce464cfd0 100644 > --- a/include/grub/emu/misc.h > +++ b/include/grub/emu/misc.h > @@ -24,6 +24,7 @@ > > #include <stdio.h> > > +#include <grub/compiler.h> > #include <grub/symbol.h> > #include <grub/types.h> > #include <grub/misc.h> > @@ -43,22 +44,17 @@ char *grub_make_system_path_relative_to_its_root (const > char *path) > int > grub_util_device_is_mapped (const char *dev); > > -#ifdef __MINGW32__ > -#define GRUB_HOST_PRIuLONG_LONG "I64u" > -#define GRUB_HOST_PRIxLONG_LONG "I64x" > -#else > #define GRUB_HOST_PRIuLONG_LONG "llu" > #define GRUB_HOST_PRIxLONG_LONG "llx" > -#endif It seems to me that this does not belong to the patch. > void * EXPORT_FUNC(xmalloc) (grub_size_t size) WARN_UNUSED_RESULT; > void * EXPORT_FUNC(xrealloc) (void *ptr, grub_size_t size) > WARN_UNUSED_RESULT; > char * EXPORT_FUNC(xstrdup) (const char *str) WARN_UNUSED_RESULT; > -char * EXPORT_FUNC(xasprintf) (const char *fmt, ...) __attribute__ ((format > (__printf__, 1, 2))) WARN_UNUSED_RESULT; > +char * EXPORT_FUNC(xasprintf) (const char *fmt, ...) __attribute__ ((format > (GNU_PRINTF, 1, 2))) WARN_UNUSED_RESULT; Commit message seems confusing. You are refering to vfprintf() but here and below you are replacing __printf__. Could fix that? Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
