On Tue, Mar 26, 2019 at 06:42:01PM -0600, Eric Snowberg wrote: > > On Mar 26, 2019, at 5:40 AM, Daniel Kiper <dki...@net-space.pl> wrote: > > On Tue, Mar 26, 2019 at 12:30:51PM +0100, Daniel Kiper wrote: > >> CC-ing Eric. > >> > >> On Mon, Mar 25, 2019 at 07:37:29PM +0100, Jesús Diéguez Fernández wrote: > >>> Rearrange return values in the function declaration of rdmsr.h and > >>> wrmsr.h. > >> > >> The most important thing here is extern drop. By the way we do cleanup. > >> Anyway, I can fix the commit message before push if you do not object. > >> So, Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> > > > > Err... Forgot to CC Eric. So, again this time with Eric address. > > Eric, could you test this patch? > > > > The V1 patch compiles and builds fine. > > I see compile errors with the V2 patch on OL7.6: > > In file included from commands/i386/rdmsr.c:29:0: > ../include/grub/i386/rdmsr.h:28:1: error: no previous prototype for > _grub_msr_read_ [-Werror=missing-prototypes] > grub_msr_read (grub_uint32_t msr_id) > ^ > In file included from commands/i386/wrmsr.c:29:0: > ../include/grub/i386/wrmsr.h:28:1: error: no previous prototype for > _grub_msr_write_ [-Werror=missing-prototypes] > grub_msr_write (grub_uint32_t msr_id, grub_uint64_t msr_value) > ^ > cc1: all warnings being treated as errors > cc1: all warnings being treated as errors
Hmmm... That looks strange. Will take closer look at it. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
