Adrian I used the attached patch and grub is now building for me with gcc-9.1.
I've no idea if this is the right solution, but it does at least work (ie. builds) which is all I require for now as I'm not personally using grub in the distribution I'm building (LibreELEC) and can't actually say if it works at run-time. Many thanks Neil On Mon, 6 May 2019 at 20:58, Neil MacLeod <n...@nmacleod.com> wrote: > > Hi Adrian > > With your patch, grub now fails to build as follows: > > fs/f2fs.c: In function 'grub_f2fs_get_block': > fs/f2fs.c:864:43: error: 'offset' may be used uninitialized in this > function [-Werror=maybe-uninitialized] > 864 | return grub_le_to_cpu32 (inode->i_addr[offset[0]]); > | ^ > cc1: all warnings being treated as errors > make[4]: *** [Makefile:33773: fs/f2fs_module-f2fs.o] Error 1 > > This is the last 1000 lines of the build log with your patch applied: > http://ix.io/1IfE > > And this is the f2fs.c used for the compilation (it includes your > patch): http://ix.io/1IfC > > Many thanks > Neil > > On Mon, 6 May 2019 at 19:19, Neil MacLeod <n...@nmacleod.com> wrote: > > > > Thanks Adrian - testing with your patch now, will be another hour or > > so until the build is complete (cross-compiling environment with own > > toolchain etc.) > > > > Just a correction, I'm testing with > > 4dd4ceec023111a4ccf69f8de6fa0885c6847a35 (current HEAD) - looks like I > > cut & pasted a rev from a different repo in my original post! > > > > Regards > > Neil > > > > On Mon, 6 May 2019 at 18:59, John Paul Adrian Glaubitz > > <glaub...@physik.fu-berlin.de> wrote: > > > > > > On 5/6/19 7:15 PM, Neil MacLeod wrote: > > > > Does anyone have a patch? > > > > > > Try the attached patch. > > > > > > Adrian > > > > > > -- > > > .''`. John Paul Adrian Glaubitz > > > : :' : Debian Developer - glaub...@debian.org > > > `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de > > > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
f2fs-uninitialized.patch
Description: Binary data
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
