The offset calculation was missing the relocation addend.

Signed-off-by: Andreas Schwab <sch...@suse.de>
---
 util/grub-mkimagexx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/grub-mkimagexx.c b/util/grub-mkimagexx.c
index bc087c2b5..d16ec63a1 100644
--- a/util/grub-mkimagexx.c
+++ b/util/grub-mkimagexx.c
@@ -1232,8 +1232,7 @@ SUFFIX (relocate_addrs) (Elf_Ehdr *e, struct 
section_metadata *smd,
                 grub_uint32_t *t32 = (grub_uint32_t *) target;
                 grub_uint16_t *t16 = (grub_uint16_t *) target;
                 grub_uint8_t *t8 = (grub_uint8_t *) target;
-                grub_int64_t off = (long)sym_addr - target_section_addr - 
offset
-                                   - image_target->vaddr_offset;
+                grub_int64_t off;
 
                 /*
                  * Instructions and instruction encoding are documented in the 
RISC-V
@@ -1243,6 +1242,7 @@ SUFFIX (relocate_addrs) (Elf_Ehdr *e, struct 
section_metadata *smd,
                  */
 
                 sym_addr += addend;
+                off = sym_addr - target_section_addr - offset - 
image_target->vaddr_offset;
 
                 switch (ELF_R_TYPE (info))
                   {
-- 
2.22.0

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to