Hi Anatoly!
On 7/30/19 10:11 AM, Anatoly Pugachev wrote:
> don't run f2fs test on systems with PAGE_SIZE > 4096 bytes.
> Since f2fs is not supported on this systems (can't mount f2fs filesystem).
Some spelling fixes and re-phrasing suggestion:
> Don't run f2fs tests on systems with PAGE_SIZE > 4096 bytes since f2fs
> is not supported on these systems and mounting a f2fs filesystems fails.
And:
+PAGE_SIZE=$(getconf PAGE_SIZE)
+F2FS_BLKSIZE=4096
+if [ $PAGE_SIZE > $F2FS_BLKSIZE ]; then
+ printf "F2FS not supported on PAGE_SIZE(%d) != %d\n" $PAGE_SIZE $F2FS_BLKSIZE
^^^^
I would write "f2fs" in lower case here for consistency with the rest of the
script.
+ exit 77
+fi
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel