On Thu, Sep 19, 2019 at 02:00:31PM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > Thanks for the quick feedback. > > On 9/18/19 3:00 PM, Daniel Kiper wrote: > > On Tue, Sep 17, 2019 at 05:54:44PM +0200, Javier Martinez Canillas wrote: > >> From: Paulo Flabiano Smorigo <pfsmor...@br.ibm.com> > >> > >> Signed-off-by: Paulo Flabiano Smorigo <pfsmor...@br.ibm.com> > >> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> > > > > May I ask you to add an explanation to the commit message why? > > If you do that you can add "Reviewed-by: Daniel Kiper > > <daniel.ki...@oracle.com>". > > > > The reason why we had this patch is that a following patch was using this > %X format specifier to print IP addresses as uppercase hexadecimal.
OK but then I would like to see patch using "%X" immediately following this one. So, both have to be posted together. And please add similar explanation as you did above to the commit message. > But as Vladimir suggested, we could just use %x and grub_toupper(). So If > adding an %X format specifier seems unnecessary and would only make grub > core bigger, then I'll just change the other patch and drop this one. TBH I prefer to have grub_printf() behavior similar to regular printf(). And I do not think that this change will increase core image size much. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
