The 'which' utility is not guaranteed to be installed either, and if it
is, its behavior is not portable either.
Conversely, the 'command -v' shell builtin is required to exist in all
POSIX 2008 compliant shells, and is thus guaranteed to work everywhere.
Examples of open-source shells likely to be installed as /bin/sh on
linux, which implement the 11-year-old standard:
bash, dash, busybox ash, ksh, mksh, zsh
A side benefit of using the POSIX portable option is that it requires
neither an external disk executable, nor (because unlike 'which', the
exit code is reliable) a subshell fork. This therefore represents a mild
speedup.
---
util/grub-mkconfig_lib.in | 2 +-
util/grub.d/30_os-prober.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in
index 0f801cab3..50f2908d2 100644
--- a/util/grub-mkconfig_lib.in
+++ b/util/grub-mkconfig_lib.in
@@ -34,7 +34,7 @@ if test "x$grub_mkrelpath" = x; then
grub_mkrelpath="${bindir}/@grub_mkrelpath@"
fi
-if which gettext >/dev/null 2>/dev/null; then
+if command -v gettext >/dev/null; then
:
else
gettext () {
diff --git a/util/grub.d/30_os-prober.in b/util/grub.d/30_os-prober.in
index 515a68c7a..ed3171417 100644
--- a/util/grub.d/30_os-prober.in
+++ b/util/grub.d/30_os-prober.in
@@ -30,7 +30,7 @@ if [ "x${GRUB_DISABLE_OS_PROBER}" = "xtrue" ]; then
exit 0
fi
-if [ -z "`which os-prober 2> /dev/null`" ] || [ -z "`which linux-boot-prober
2> /dev/null`" ] ; then
+if ! command -v os-prober > /dev/null || ! command -v linux-boot-prober >
/dev/null ; then
# missing os-prober and/or linux-boot-prober
exit 0
fi
--
2.23.0
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
