Hello Daniel, On 10/23/19 11:19 AM, Daniel Kiper wrote: > On Fri, Oct 18, 2019 at 02:42:20PM +0200, Javier Martinez Canillas wrote: >> From: Peter Jones <pjo...@redhat.com> >> >> Add a grub_util_readlink() helper function. > > OK but for patches like that one I will be always asking for an explannation > in the commit message why we need this functionality/function(s). So, please > always add it. If you do that for this ptach feel free to add my RB. >
Yes, sorry for missing that there wasn't an explanation about why the change is needed. I've added now a proper commit message for v2. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
