On 10/28/19 4:13 PM, Daniel Kiper wrote: > On Wed, Oct 23, 2019 at 03:00:32PM +0200, Javier Martinez Canillas wrote: >> From: Paulo Flabiano Smorigo <pfsmor...@br.ibm.com> >> >> This patch implements a search for a specific configuration when the config >> file is on a remoteserver. It uses the following order: >> 1) DHCP client UUID option. >> 2) MAC address (in lower case hexadecimal with dash separators); >> 3) IP (in upper case hexadecimal) or IPv6; >> 4) The original grub.cfg file. >> >> This procedure is similar to what is used by pxelinux and yaboot: >> http://www.syslinux.org/wiki/index.php/PXELINUX#config >> >> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=873406 >> >> Signed-off-by: Paulo Flabiano Smorigo <pfsmor...@br.ibm.com> >> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> >> Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> > > Did you at least build test whole patchset? I do not think so. > Please do that before posting any patch on grub-devel. I do not > accept any patch which at least does not build. Details below..
I do build and test the functionality for all the posted patches but just noticed that I was calling configure with the --disable-werror option on my build script... and that's why I missed these issues. Sorry about that, I fixed my script now so it won't happen again. > Plus some nitpicks... > I'll address these also in v5, thanks again for your feedback and review. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
