Hello Daniel, On 11/29/19 4:53 PM, Daniel Kiper wrote: > On Thu, Oct 31, 2019 at 11:33:39AM +0100, Javier Martinez Canillas wrote: >> From: Lenny Szubowicz <lszub...@redhat.com> >> >> Some tftp servers do not handle multiple consecutive slashes correctly; >> this patch avoids sending tftp requests with non-normalized paths. >> >> Signed-off-by: Lenny Szubowicz <lszub...@redhat.com> >> Signed-off-by: Mark Salter <msal...@redhat.com> >> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> > > Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> > > Except some nitpicks which I fix before committing... >
Thanks a lot for fixing the issues and taking the patch. >> --- >> >> grub-core/net/tftp.c | 28 +++++++++++++++++++++++++--- >> 1 file changed, 25 insertions(+), 3 deletions(-) >> >> diff --git grub-core/net/tftp.c grub-core/net/tftp.c >> index 7d90bf66e76..6dbb9cdbb7a 100644 >> --- grub-core/net/tftp.c >> +++ grub-core/net/tftp.c >> @@ -300,6 +300,25 @@ destroy_pq (tftp_data_t data) >> grub_priority_queue_destroy (data->pq); >> } >> >> +/* Create a normalized copy of the filename. >> + Compress any string of consecutive forward slashes to a single forward >> + slash. */ > > https://www.gnu.org/software/grub/manual/grub-dev/grub-dev.html#Multi_002dLine-Comments > Sorry, I'll make sure that comments are correct the next time. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
