On 5/23/20 5:30 PM, Jacob Paul via Grub-devel wrote: > Currently, grub_multiboot_load_elf() will throw an error if the program > header is at a too high offset (since it would be outside the allocated > buffer space of MULTIBOOT_SEARCH bytes). It is understandable why it does > this, since 99.99% of all cases e_phoff has a value of 0x34 or 0x40. So, to > be able to support a (uncommon) circumstance like this, the program header > can be loaded into a separate buffer if needed, and then freed at the end. > The only downside to this is that grub_multiboot_load_elf() must at every > return statement check if phdr_base is a separate buffer and if so > de-allocate it.
I would suggest adding newlines in the description as otherwise the text might end in one line in the actual commit message. Although I'm not sure whether "git-am" adds automatic line breaks. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
