On Fri, Jul 31, 2020 at 07:01:56AM -0500, Glenn Washburn wrote:
> A header line is added to luks_script for easier comprehension of fields by
> user. And the crypto disk name and source device names are added.
>
> Signed-off-by: Glenn Washburn <developm...@efficientek.com>
> ---
> grub-core/disk/cryptodisk.c | 28 ++++++++++++++++++++++------
> 1 file changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
> index 9399849b6..2c6e73b39 100644
> --- a/grub-core/disk/cryptodisk.c
> +++ b/grub-core/disk/cryptodisk.c
> @@ -1206,35 +1206,48 @@ hex (grub_uint8_t val)
> }
>
> /* Open a file named NAME and initialize FILE. */
> +#define STR(s) #s
> +#define MAX_ID_PRINT 10000
> static char *
> luks_script_get (grub_size_t *sz)
> {
> grub_cryptodisk_t i;
> grub_size_t size = 0;
> char *ptr, *ret;
> + const char header[] = N_("<type> <devname> <source disk> <uuid> <sector "
> + "offset> <sector size> <cipher> <key> <options>\n");
> + static char errmsg[] = N_("Can not list more than " STR(MAX_ID_PRINT)
> + " crypto devices.\n");Not sure, but this seems like a backwards-incompatible change to me, right? In case anybody has been looping over this list, he'll not know to skip the first line. Patrick
signature.asc
Description: PGP signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
