On Fri, Nov 27, 2020 at 03:03:37AM -0600, Glenn Washburn wrote:
> We need to convert the sectors from the size of the underlying device to the
> cryptodisk sector size; segment.size is in bytes which need to be converted
> to cryptodisk sectors as well. And counter-intuitively, grub_disk_get_size
> returns the total number of device native sectors.

Should not we change the name to, e.g., grub_disk_native_sectors() then?
Could you do that?

> Also, removed an empty statement.
>
> Signed-off-by: Glenn Washburn <developm...@efficientek.com>

Otherwise Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to