On Mon, Jan 11, 2021 at 11:04:51AM +0800, Tianjia Zhang wrote:
> `preferred_address` has been assigned to GRUB_LINUX_BZIMAGE_ADDR
> during initialization in grub_cmd_linux(). The assignment here
> is redundant and should be removed.
>
> Signed-off-by: Tianjia Zhang <tianjia.zh...@linux.alibaba.com>
Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com>
Daniel
> ---
> grub-core/loader/i386/linux.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c
> index 3a06785b2..9f74a96b1 100644
> --- a/grub-core/loader/i386/linux.c
> +++ b/grub-core/loader/i386/linux.c
> @@ -751,14 +751,11 @@ grub_cmd_linux (grub_command_t cmd __attribute__
> ((unused)),
> prot_init_space = page_align (prot_size);
> if (relocatable)
> preferred_address = grub_le_to_cpu64 (lh.pref_address);
> - else
> - preferred_address = GRUB_LINUX_BZIMAGE_ADDR;
> }
> else
> {
> min_align = align;
> prot_size = prot_file_size;
> - preferred_address = GRUB_LINUX_BZIMAGE_ADDR;
> /* Usually, the compression ratio is about 50%. */
> prot_init_space = page_align (prot_size) * 3;
> }
> --
> 2.19.1.3.ge56e4f7
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
