First of all, sorry for late reply but I am busy... On Thu, Apr 29, 2021 at 05:43:48PM +0300, Egor Ignatov wrote: > This patch fixes an old bug when backspace key does not work in the > username login prompt. It allows BIDI type BN characters (control > chars like '\b') in the visual line. And when grub_gfxterm_putchar > recieves this line it successfully processes backspace.
Did you test this patch with other BIDI type BN characters [1]? I am not convinced it works with them as expected. I think earlier version of your patch was more promising... > Signed-off-by: Egor Ignatov <eg...@altlinux.org> > --- > Hi, I'd like to try to propose this patch again. I'm new to the open > source community, so any feedback and suggestions will be appreciated. > > grub/grub-core/normal/charset.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/grub/grub-core/normal/charset.c b/grub/grub-core/normal/charset.c > index b0ab47d73..30e819bdf 100644 > --- a/grub/grub-core/normal/charset.c > +++ b/grub/grub-core/normal/charset.c > @@ -925,6 +925,7 @@ grub_bidi_line_logical_to_visual (const grub_uint32_t > *logical, > pop_stack (); > break; > case GRUB_BIDI_TYPE_BN: > + visual_len++; > break; > case GRUB_BIDI_TYPE_R: > case GRUB_BIDI_TYPE_AL: Daniel [1] https://www.compart.com/en/unicode/bidiclass/BN _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
