On Tue, Jul 20, 2021 at 05:14:46PM -0400, Stefan Berger wrote: > From: Daniel Axtens <[email protected]> > > HEAP_MAX_ADDR is confusing. Currently it is set to 32MB, except > on ieee1275 on x86, where it is 64MB. > > There is a comment which purports to explain it: > > /* If possible, we will avoid claiming heap above this address, because it > seems to cause relocation problems with OSes that link at 4 MiB */ > > This doesn't make a lot of sense when the constants are well above 4MB > already. It was not always this way. Prior to > commit 7b5d0fe4440c ("Increase heap limit") in 2010, HEAP_MAX_SIZE and > HEAP_MAX_ADDR were indeed 4MB. However, when the constants were increased > the comment was left unchanged. > > It's been over a decade. It doesn't seem like we have problems with > claims over 4MB on powerpc or x86 ieee1275. (sparc does things completely > differently and never used the constant.) > > Drop the constant and the check. > > The only use of HEAP_MIN_SIZE was to potentially override the > HEAP_MAX_ADDR check. It is now unused. Remove it. > > Signed-off-by: Daniel Axtens <[email protected]> > Tested-by: Stefan Berger <[email protected]>
Nit, you should add your Signed-off-by after Daniel's one. I can make it for you if you do not object. Otherwise: Reviewed-by: Daniel Kiper <[email protected]> Daniel _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
