On Thu, Sep 02, 2021 at 02:32:48PM +0200, Erwan Velu wrote: > [...] > The ext_cmd change is cool except the linker isn't happy as it cannot find the > associated symbols. > I asked a question on the IRC channel on this point. > I'm not familiar with the dependencies definition in this project, where > should > I work to get ext_cmd being linked with kern/efi ? > I tried inside grub-core/Makefile.core.def without much luck for now. I even > wonder if we can linked modules with kern. > If you can point me in the right direction for this. I checked some other > commits around ext_cmd but none changes the makefiles.
Ugh... Sorry, I forgot extcmd interface is not available in the GRUB kernel. So, please ignore this comment. > I also forgot to mention, your review was high quality for a newcomer. You > point to the sample commits and that's very useful to see the expectations. > Thanks for that. Nice to hear that. Thank you! Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
