On Wed, Dec 08, 2021 at 12:28:56PM -0600, Glenn Washburn wrote: > On Wed, 8 Dec 2021 17:41:32 +0100 > Daniel Kiper <dki...@net-space.pl> wrote: > > > On Sat, Dec 04, 2021 at 01:15:46AM -0600, Glenn Washburn wrote: > > > Update such that "cryptomount -u UUID" will not print two error messages > > > when an invalid passphrase is given and the most relevant error message > > > will be displayed. > > > > > > Improve error message which is displayed when a UUID is specified, but no > > > cryptodisk backends find a disk with that UUID. > > > > > > Also, make cryptomount return failure when no cryptodisk modules are > > > loaded, > > > which allows an error to be displayed notifying the user that they'll want > > > to load a backend module to make cryptomount useful. > > > > Is it possible to split this patch into 3 separate patches? > > I think the first and last hunks will be difficult to untangle, which > is part of what I expect you're asking for. The commit message has > three sections, which can be broken in to three patches easily, but two > of the patches would be fairly trivial (one is the second hunk and the > other is changing an error string to be more descriptive. Can you > clarify that I've understood you correctly and if not, give more detail > in what you're looking for?
Yes, please split this patch into two or three patches. The general rule is: one logical change per patch. Exceptions should not happen often... Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel