Dear Daniel,
Am 11.03.22 um 00:35 schrieb Daniel Kiper:
Latest GCC may complain in that way:
Just for the record, what is the latest GCC for you? 12?
In file included from ../include/grub/disk.h:31, from ../include/grub/file.h:26, from ../include/grub/loader.h:23, from loader/i386/bsd.c:19: loader/i386/bsd.c: In function ‘grub_cmd_openbsd’: ../include/grub/misc.h:71:10: error: ‘ptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 71 | return grub_memmove (dest, src, n); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ loader/i386/bsd.c:266:9: note: ‘ptr’ was declared here 266 | void *ptr; | ^~~ So, let's fix it by assigning NULL to ptr in grub_bsd_add_meta(). Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- grub-core/loader/i386/bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/loader/i386/bsd.c b/grub-core/loader/i386/bsd.c index 5f3290ce1..346c4f14a 100644 --- a/grub-core/loader/i386/bsd.c +++ b/grub-core/loader/i386/bsd.c @@ -263,7 +263,7 @@ grub_err_t grub_bsd_add_meta (grub_uint32_t type, const void *data, grub_uint32_t len) { grub_err_t err; - void *ptr; + void *ptr = NULL;err = grub_bsd_add_meta_ptr (type, &ptr, len);if (err)
It’s a bogus warning though, as `grub_bsd_add_meta_ptr()` return an error when ptr wasn’t initialized yet, right?
Kind regards, Paul _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
