On Mon, May 16, 2022 at 04:49:45PM -0500, Glenn Washburn wrote: > Note: Description here has changed since last time, the last few sentences, > which describe a method for allowing backends to bypass the read hook on > the source disk. > > Updates since v1: > * Add marge comment block describing at a high level the read hook operation > and assumptions. > * Add code to unset read hook on source disk when exiting > grub_cryptodisk_scan_device_real(). A couple return calls were converted > into gotos so that logical flows to one exit point. [snip]
I've reviewed this patch series, and except for a single nit the changes all look good to me. So please feel free to add my Reviewed-by: Patrick Steinhardt <p...@pks.im> , regardless of whether you decide to apply my prosed nit in 2/3 or not. Patrick
signature.asc
Description: PGP signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel