Dear Michał,

Thank you for your patch.

Am 19.07.23 um 00:48 schrieb Michał Grzelak:
During configuration of SDL2, variable enable_grub_emu_sdl2 is checked
whether to throw an error message. Howerever, error could not happen

However

because two unequal strings were compared. Fix this by referencing
value of enable_grub_emu_sdl2, not name.

Fixes: 17d6ac1a7 (emu: Add SDL2 support)

Signed-off-by: Michał Grzelak <mchl.gr...@gmail.com>
---
  configure.ac | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 01500ffdf..27c5918fa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1609,7 +1609,7 @@ if test "$platform" = emu; then
              AC_SUBST(HAVE_SDL2)],
              [grub_emu_sdl2_excuse="libSDL2 libraries are required to build 
\`grub-emu' with SDL2 support"])
    [fi]
-  if test x"enable_grub_emu_sdl2" = xyes && test x"$grub_emu_sdl2_excuse" != x 
; then
+  if test x"$enable_grub_emu_sdl2" = xyes && test x"$grub_emu_sdl2_excuse" != 
x ; then
      AC_MSG_ERROR([SDL2 support for grub-emu was explicitly requested but 
can't be compiled ($grub_emu_sdl2_excuse)])
    fi
    if test x"$grub_emu_sdl2_excuse" = x ; then

Reviewed-by: Paul Menzel <pmen...@molgen.mpg.de>


Kind regards,

Paul

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to