On Fri, Jun 28, 2024 at 02:54:53PM +0300, Vladimir 'phcoder' Serbinenko wrote: > > + if (protector == NULL || protector->name == NULL || grub_strlen > > (protector->name) == 0) > > + return GRUB_ERR_BAD_ARGUMENT; > > + > Here and in the other places you miss grub_error. Note that the > message in such technical cases should be left untranslated (no N_ > mark). > Ok. I'll add grub_error to provide the better error messages.
> > + if (protector == NULL || grub_strlen (protector) == 0) > > Rather than checking strlen just do protector[0] == '\0' Ah, right. It's more efficient. Gary Lin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
