On Fri, Jun 28, 2024 at 04:18:51PM +0800, Gary Lin via Grub-devel wrote: > Do a few things to make asn1 tests compile as part of grub: > > - include asn1_test.h only > > - rename the main functions to the test names > > - remove 'verbose' and the unnecessary printf() > > - print the error messages with grub_printf() > > - return either 0 or 1 to reflect the results of the tests > > - replace the system functions with grub functions, ex: memcmp() -> > grub_memcmp()
When I look at this commit message I think this patch can be split further. OK, the last bullet can stay as is. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
