Any feedback on this? I can regenerate and resend the patch if there are any conflicts with other updates.
Thanks, Andrew On Sat, Aug 31, 2024 at 10:31 PM Andrew Hamilton <adham...@gmail.com> wrote: > Correct incorrect handling of routes being maintained when an > associated interface is deleted. Previously the route(s) for an interface > being removed were not deleted. This resulted in displaying corrupted > output to the console in the following sequence: > net_add_addr > if0 emu0 192.168.100.2 > net_ls_routes if0:local 192.168.100.0/24 if0 > net_del_addr if0 > net_ls_routes if0:local 192.168.100.0/24 ??? > ... > net_ls_routes > if0:local 192.168.100.0/24 ?7? > The fields including the question marks above will contain pseudo-random > data from the heap which may change over time. In some cases this may > have resulted in crashes as well after a route was deleted and attempted > to be used in actual network routing operations. > With this update, routes mapped to a deleted interface will be deleted. > > In addition, a test was added for testing the network commands. This > test will still run without the net.c change but it will fail. > With the net.c change, this test will pass on grub-emu and be > skipped for other platforms. > > Changes since v1: > (Ref: > https://lists.gnu.org/archive/html/grub-devel/2024-08/msg00138.html) > - Add net_test > - Resubmit net.c change due to incorrect patch submission before. > > Andrew Hamilton (2): > Add a test for the grub-emu environment to test various network > commands such as adding addresses, updating routes, etc. > Correct incorrect handling of routes being maintained when an > associated interface is deleted. Previously the route(s) for an > interface being removed were not deleted. This resulted in > displaying corrupted output to the console in the following > sequence: net_add_addr if0 emu0 192.168.100.2 net_ls_routes > if0:local 192.168.100.0/24 if0 net_del_addr if0 net_ls_routes > if0:local 192.168.100.0/24 ??? ... net_ls_routes if0:local > 192.168.100.0/24 ?7? The fields including the question marks above > will contain pseudo-random data from the heap which may change over > time. In some cases this may have resulted in crashes as well after > a route was deleted and attempted to be used in actual network > routing operations. With this update, routes mapped to a deleted > interface will be deleted. > > Makefile.util.def | 6 ++ > grub-core/net/net.c | 17 ++++ > tests/net_test.in | 187 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 210 insertions(+) > create mode 100644 tests/net_test.in > > -- > 2.39.2 > >
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
