On Wed, Oct 16, 2024 at 11:54:38AM -0600, Leo Sandoval wrote:
> An Internal (at Red Hat) static soure code scan detected the issue below,
> pointing to an use-after-free scenario so remove the extra file close
> call.
>
>     Error: USE_AFTER_FREE (CWE-416):
>     grub-2.06/grub-core/commands/legacycfg.c:194: freed_arg: 
> "grub_file_close" frees "file".
>     grub-2.06/grub-core/commands/legacycfg.c:201: deref_arg: Calling 
> "grub_file_close" dereferences freed pointer "file".
>     #  199|         if (!args)
>     #  200|           {
>     #  201|->           grub_file_close (file);
>     #  202|             grub_free (suffix);
>     #  203|             grub_free (entrysrc);
>
> Signed-off-by: Leo Sandoval <lsand...@redhat.com>

Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to