Le jeu. 3 avr. 2025, 18:06, Daniel Kiper <dki...@net-space.pl> a écrit :

> On Tue, Apr 01, 2025 at 03:58:56PM +0300, Vladimir Serbinenko wrote:
> > Libgcrypt code assumes that on x64 all SSE registers are fair game.
> > While it's true that CPUs in question support it, we disable it in
> > our compilation options. Disable the offending optimization.
> >
> > Signed-off-by: Vladimir Serbinenko <phco...@gmail.com>
> > ---
> >  .../lib/libgcrypt-patches/02_keccak_sse.patch | 23 +++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >  create mode 100644 grub-core/lib/libgcrypt-patches/02_keccak_sse.patch
> >
> > diff --git a/grub-core/lib/libgcrypt-patches/02_keccak_sse.patch
> b/grub-core/lib/libgcrypt-patches/02_keccak_sse.patch
> > new file mode 100644
> > index 000000000..c153518da
> > --- /dev/null
> > +++ b/grub-core/lib/libgcrypt-patches/02_keccak_sse.patch
> > @@ -0,0 +1,23 @@
> > +commit b0cf06271da5fe20360953a53a47c69da89669cd
> > +Author: Vladimir Serbinenko <phco...@gmail.com>
> > +Date:   Sun Apr 7 06:33:11 2024 +0300
> > +
> > +    keccak: Disable acceleration with SSE asm
> > +
> > +    Libgcrypt code assumes that on x64 all SSE registers are fair game.
> > +    While it's true that CPUs in question support it, we disable it in
> > +    our compilation options. Disable the offending optimization.
>
> Please add your SOB here too. If you do that you can add
> Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> here and above...
>
> And it would be nice if you fix these warnings:
>
>   Applying: keccak: Disable acceleration with SSE asm
>   .git/rebase-apply/patch:29: trailing whitespace.
>
>   .git/rebase-apply/patch:32: trailing whitespace.
>
>   warning: 2 lines add whitespace errors.
>
Impossible without breaking the patch

>
> Daniel
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to