On Thu, 8 May 2025 at 17:30, Vladimir 'phcoder' Serbinenko <
phco...@gmail.com> wrote:
> Le jeu. 8 mai 2025, 15:49, Yair Yarom <ir...@cs.huji.ac.il> a écrit :
>
>> +#include <grub/normal.h>
>>
> What requires normal.h? Just curious
>
grub_file_getline is in normal.h
> +struct grub_testpci_devlist {
>> + char** devices;
>> + int n_devices;
>> + int s_devices;
>>
> What is s_devices? Maybe a more descriptive name? From reading code I see
> that it's the number of allocated devices. Maybe name it allocated_devices?
>
I'll change it to devices_size with a comment (technically n_devices is the
number of allocated devices).
> + grub_file_t listfile = grub_file_open(ctxt->state[0].arg,
>> GRUB_FILE_TYPE_NONE);
>>
> File type is wrong
>
What should be the file type? Should I create a new one (e.g.
GRUB_FILE_TYPE_DEVICE_LIST) ? If so, should I add it to
shim_lock_verifier_init? (we don't use secure boot, and I'm less familiar
with it)
Thanks,
Yair.
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
