Thanks I will make the suggested fixes and sent out a v2 later.

- Andrew

On Mon, May 19, 2025 at 11:56 AM Daniel Kiper <dki...@net-space.pl> wrote:

> On Fri, May 16, 2025 at 08:26:44PM -0500, Andrew Hamilton wrote:
> > 1. Correct ntfs_test test failures around attempting to validate
> attribute list entries as attributes. The NTFS code uses common logic in
> some places to parse both attributes and attribute_lists which complicates
> validation.
> > 2. Correct ntfs_test test failures around attempting to validate
> attribute run list values. The calculation was incorrect for the 'curr'
> variable.
>
> Please split this patch into 2. Each patch should do one logical thing
> and have proper description of a problem and fix. And please wrap lines
> in the commit message at around 80 characters.
>
> Similar comment applies to the other patches.
>
> > Fixes: 067b6d225d482280abad03944f04e30abcbdafa1
>
> Fixes: 067b6d225 (fs/ntfs: Implement attribute verification)
>
> Daniel
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to