On Mon, Aug 11, 2025 at 7:13 AM Vladimir 'phcoder' Serbinenko <phco...@gmail.com> wrote: > > > > Le lun. 11 août 2025, 16:49, Neal Gompa <ngomp...@gmail.com> a écrit : >> >> On Fri, Aug 1, 2025 at 7:41 AM Vladimir Serbinenko <phco...@gmail.com> wrote: >> > >> > Signed-off-by: Vladimir Serbinenko <phco...@gmail.com> >> > --- >> > grub-core/fs/zfs/zfs.c | 502 ++++++++++++++++++++++++++++++++---- >> > grub-core/fs/zfs/zfscrypt.c | 335 +++++++++++++++++++++--- >> > include/grub/zfs/zfs.h | 54 +++- >> > 3 files changed, 793 insertions(+), 98 deletions(-) >> > >> > diff --git a/grub-core/fs/zfs/zfs.c b/grub-core/fs/zfs/zfs.c >> > index b88a2b032..da1661680 100644 >> > --- a/grub-core/fs/zfs/zfs.c >> > +++ b/grub-core/fs/zfs/zfs.c >> > @@ -227,6 +227,10 @@ struct subvolume >> > grub_uint64_t txg; >> > grub_uint64_t algo; >> > } *keyring; >> > + >> > + struct grub_zfs_datto_key key_datto; >> > + >> > + int is_datto_encrypted; >> > }; >> >> Do we really need to call this "datto ZFS encryption"? It's been a >> while since I was engaged in OpenZFS development, but I'm pretty sure >> it's still the standard ZFS native encryption for OpenZFS. > > We need to call it something. There are 2 ways of encrypting: Oracle and > Datto. And we need to distinguish then somehow. Given that "datto" is part of > its feature name I thought it's a good possibility for naming it in this > patch.
Yeah, this is probably fine, but it should be noted somehow that this is the OpenZFS encryption feature. -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
