On Fri, 19 Sep 2025 15:45:05 -0600 Leo Sandoval via Grub-devel <[email protected]> wrote:
> Apparently the man page is outdated because the option '-w' is shown > but not on 'mkfs.hfsplus --usage'. According to Gemini > > The -w option is usedto add an HFS wrapper around an HFS Plus file > system, which is sometimes required for compatibility with older > Mac OS 9 systems. However, this is not a standard or commonly used > option and may not be available in all versions of the hfsprogs package, > especially on Linux. So? This is not a reason to not test for something. The tests are meant to _test_ GRUB, not to be neutered the lowest common denominator so they can be run successfully on every OS. Unless something has changed recently, my understanding is that the tests are only officially supported on Debian. Even on Debian there are issues, because they neutered their hfs-progs so we can't test hfs fully on newer Debians. > > Signed-off-by: Leo Sandoval <[email protected]> > --- > tests/util/grub-fs-tester.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in > index cac58dafa8..599b5f1762 100644 > --- a/tests/util/grub-fs-tester.in > +++ b/tests/util/grub-fs-tester.in > @@ -727,7 +727,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" > "$MAXLOGSECSIZE" 1); do > "mkfs.hfsplus" -b $BLKSIZE -v "$FSLABEL" "${MOUNTDEVICE}" > dd if=/dev/urandom of="${MOUNTDEVICE}" bs=1 seek=$((0x468)) > conv=notrunc count=8 ;; > x"hfsplus_wrap") > - "mkfs.hfsplus" -w -b $BLKSIZE -v "$FSLABEL" "${MOUNTDEVICE}" > + "mkfs.hfsplus" -b $BLKSIZE -v "$FSLABEL" "${MOUNTDEVICE}" This is not a good change. Notice that now the test is the same as the one above. This test specifically tests that an HFS+ wrapped like this passes the filesystem test. That is that GRUB supports these types of filesystems. This change indicates that the tests are testing such a scenario, but is actually testing something else. So either we remove this test or we continue testing for this. But definitely do not pretend to test for something and do something else. I believe this still works in Debian, so perhaps Redhat should include Debian's changes that make -w work. One idea, which has its short comings, would be to create an fs image and use that, instead of requiring testing environments to build their own image. Glenn > dd if=/dev/urandom of="${MOUNTDEVICE}" bs=1 seek=$((0x468)) > conv=notrunc count=8 > MOUNTFS="hfsplus";; > x"hfsplus_casesens") _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
