Adding a check for invalid partition number. grub_strtoul() can fail in several scenarios like invalid input, overflow, etc will result in an invalid partition number which could lead to an undefined behavior.
Signed-off-by: Avnish Chouhan <[email protected]> --- grub-core/kern/ieee1275/openfw.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/grub-core/kern/ieee1275/openfw.c b/grub-core/kern/ieee1275/openfw.c index 3b492dd..e82dc34 100644 --- a/grub-core/kern/ieee1275/openfw.c +++ b/grub-core/kern/ieee1275/openfw.c @@ -512,7 +512,18 @@ grub_ieee1275_encode_devname (const char *path) } if (partition && partition[0]) { - unsigned int partno = grub_strtoul (partition, 0, 0); + char *endptr; + grub_errno = GRUB_ERR_NONE; + unsigned int partno = grub_strtoul (partition, &endptr, 0); + + if (grub_errno != GRUB_ERR_NONE || *endptr != '\0') + { + grub_free (partition); + grub_free (device); + grub_free (encoding); + grub_error (GRUB_ERR_BAD_ARGUMENT, N_("invalid partition number")); + return NULL; + } *optr++ = ','; -- 2.52.0 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
