On Fri, Jan 30, 2026 at 04:08:11PM +0530, Avnish Chouhan wrote: > On 2026-01-29 16:44, Michal Suchánek wrote: > > On Thu, Jan 29, 2026 at 12:52:30PM +0300, Vladimir 'phcoder' Serbinenko > > wrote: > > > How does it handle PPC macs? They don't use install device > > > > As already commented on v3 this is in the else branch of the PPC Mac > > detection which is not clear from how the patch is written. > > > > It could be better in that regard but that part of feedback was > > rejected. > > Hi Michal, > > Please don't get me wrong. I didn't reject your feedback. Just that I felt > it will be better if we do this way. But after my reply, I haven't heard > from you. You replied to it after I sent v4. I have shared the whole code > block where I have added an else condition in my earlier reply. > > If "if (macppcdir)" evaluates true (where I have added an else). this means > it is indeed a Mac machine. And in this "if (macppcdir)" block, we set > "is_prep = 0;". So adding an if condition based on "is_prep" after this "if > (macppcdir)" rather than adding new else condition. I found the latter > better, having an else rather than if with "is_prep = 0;". > > But I really don't mind changing the way you like :) Please let me know, > I'll change it v5. > Thank you!
Either way should work. The repeated questions about how to handle the mac case suggest that this way is not very clear. There is common practice of adding comments to preprocessor #else to make it clear what the other branch is about, and reducing nesting of the C if/else. Not sure it would do much for this particular case. Thanks Michal _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
