Hi Avnish,

Noticed the following build error on the powerpc-ieee1275 platform.

disk/ieee1275/ofdisk.c:288:50: error: ‘EXTEND_PATH_64’ undeclared (first use in this function)
  288 |   buf = grub_malloc (grub_strlen (alias->path) + EXTEND_PATH_64);

disk/ieee1275/ofdisk.c: In function ‘dev_iterate_fcp_nvmeof’:
disk/ieee1275/ofdisk.c:396:50: error: ‘EXTEND_PATH_512’ undeclared (first use in this function)
  396 |   buf = grub_malloc (grub_strlen (alias->path) + EXTEND_PATH_512);


Build Steps followed:

1. Apply this patch series on top of latest GRUB 2 from https://cgit.git.savannah.gnu.org/cgit/grub.git/
2. ./configure
3. make


config options for the build

*******************************************************
GRUB2 will be compiled with following components:
Platform: powerpc-ieee1275
With devmapper support: Yes
With memory debugging: No
With disk cache statistics: No
With boot time statistics: No
efiemu runtime: No (only available on i386)
grub-mkfont: Yes
grub-mount: Yes
grub-protect: No (need libtasn1 library)
starfield theme: Yes
With DejaVuSans font from /usr/share/fonts/dejavu-sans-fonts/DejaVuSans.ttf
With libzfs support: No (need zfs library)
Build-time grub-mkfont: Yes
Without unifont
With liblzma from -llzma (support for XZ-compressed mips images)
With stack smashing protector: No
*******************************************************


Am I missing something here?
Please let me know.

thanks,
Srish.

On 7/30/25 11:03 AM, Avnish Chouhan wrote:
This patch series adds support of NVMeoFC and NVMe Multipath splitter on grub. 
It consists of six
patches.

Patch 1/6 (0001-ieee1275-powerpc-implements-fibre-channel-discovery-.patch):
grub-ofpathname doesn't work with fibre channel because there is no
function currently implemented for it.
This patch enables it by prividing a function that looks for the port
name, building the entire path for OF devices.

Patch 2/6(0002-ieee1275-implement-FCP-methods-for-WWPN-and-LUNs.patch):
This patch enables the fcp-targets and fcp-luns methods which are
responsible to get WWPNs and LUNs for fibre channel devices.
Those methods are specially necessary if the boot directory and grub
installation are in different FCP disks, allowing the dev_iterate()
to find the WWPNs and LUNs when called by searchfs.uuid tool.

Patch 3/6(0003-change-partition-parser.patch):
Usually grub will parse the PFW arguments by searching for the first occurence 
of the character ':'.
However, we can have this char more than once on NQN.
This patch changes the logic to find the last occurence of this char so we can 
get the proper values
for NVMeoFC

Patch 4/6(0004-ieee1275-add-support-for-NVMeoFC.patch):
This patch implements the functions to scan and discovery of NVMeoFC.

Patch 5/6(0005-ieee1275-ofpath-enable-NVMeoF-logical-device-transla.patch):
This patch add code to enable the translation of logical devices to the of 
NVMeoFC paths.

Patch 6/6(0006-ieee1275-support-added-for-multiple-nvme-bootpaths.patch)
This patch sets mupltiple NVMe boot-devices for more robust boot.
Scenario where NVMe multipaths are available, all the available bootpaths (Max 
5)
will be added as the boot-device.

Avnish Chouhan (5):
   ieee1275: implement FCP methods for WWPN and LUNs
   ieee1275: change the logic of ieee1275_get_devargs()
   ieee1275: add support for NVMeoFC
   ieee1275: ofpath enable NVMeoF logical device translate
   ieee1275: support added for multiple nvme bootpaths

Diego Domingos (1):
   ieee1275/powerpc: implements fibre channel discovery for ofpathname

  grub-core/disk/ieee1275/ofdisk.c
  grub-core/kern/ieee1275/openfw.c
  grub-core/osdep/linux/ofpath.c
  grub-core/osdep/unix/platform.c
  include/grub/util/ofpath.h
  include/grub/util/install.h
  6 files changed


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to